search

RestComm / smscgateway

RestComm SMS Gateway (SMSC) to send/receive SMS from/to Operators Network (GSM)
http://www.restcomm.com/
GNU Affero General Public License v3.0
126 stars 112 forks source link

SMSC generate 2 CDRs in case of permanent error #288

Open yevgenys opened 6 years ago

yevgenys commented 6 years ago

scenario:

  1. smscPropertiesManagement.getGenerateTempFailureCdr() set to True(by default)
  2. function onDeliveryError receive ErrorAction.permanentFailure
  3. function onDeliveryError generate 2 CDRs, one with temporary failure, second with permanent

temporary error: https://github.com/RestComm/smscgateway/blob/5f69047862411f5ee1db6364019dbd09ac46d022/core/slee/services/sbbs/src/main/java/org/mobicents/smsc/slee/services/mt/MtCommonSbb.java#L396

permanent error: https://github.com/RestComm/smscgateway/blob/5f69047862411f5ee1db6364019dbd09ac46d022/core/slee/services/sbbs/src/main/java/org/mobicents/smsc/slee/services/mt/MtCommonSbb.java#L479

this seems like a bug that there are 2 CDRs