search

RestComm / ussdgateway

RestComm USSD Gateway
http://www.restcomm.com/
GNU Affero General Public License v3.0
89 stars 102 forks source link

GUI: Delete Short Cut not working when its invalid #48

Open FerUy opened 7 years ago

FerUy commented 7 years ago

When trying to deleting an invalid USSD shortcut by clicking in the appropriate button in "Routing Rule" window, nothing happens. Hence, a badly set shortcut is impossible to fix or delete. See attached image where accidentally 333" was configured but then impossible to correct or delete (tested with Google Chrome and Mozilla Firefox with identical results). That's all that happens, the tooltip appears but the rule stays no matter what you do in the GUI. If the shortcut is properly set (e.g. 101#), then it works normally. However, bad shortcut setting may happen and there's no fix available today for such scenario. ussd-gw_delete_bad_shortcut_not_working

vetss commented 7 years ago

Ho @FerUy

I need to test it. Do not understan the reason as for now.

FerUy commented 7 years ago

Hi @vetss, sure. I accidentally faced it today while configuring a short code for a demo, never seen it before.

vetss commented 7 years ago

@FerUy I can not reproduce the ussue locally. I can remove even a rule with "333". May be the reason is other ? Can you constanly reproduce the issue (may be steps for me). Also may be some logs in GUI console or server.log ?

FerUy commented 7 years ago

OK @vetss, I will try again and provide logs.

FerUy commented 7 years ago

Hi @vetss, preparing a training a managed to test this. I get the following from Chrome console:

Uncaught SyntaxError: Invalid or unexpected token (function(event){deleteScRoutingRule('*333})

or see image below. Apparently it doesn't recognize the double quotes. Server.log shows absolutely nothing regarding the event.

ussd-gw_delete_bad_shortcut_not_working_browserconsolelog