search

RestComm / ussdgateway

RestComm USSD Gateway
http://www.restcomm.com/
GNU Affero General Public License v3.0
88 stars 102 forks source link

Issue #72 & #76: Add dialog duration and ussdString to CDRState #79

Closed abdulazizali77 closed 6 years ago

abdulazizali77 commented 6 years ago

Clone of https://github.com/RestComm/ussdgateway/pull/75 @vetss Sergey, please have a look. Have additionally added jodatime dependency to bootstrap and squashed commits.

Have run local tests using hsqldb

INSERT INTO USSD_GW_CDRS VALUES('474dfa80-5c70-438a-ae0d-43c881a642fe',2,8,1,NULL,NULL,NULL,8,0,4,'9960639902','*519#',1,1,'111111',1,1,'222222',NULL,NULL,NULL,NULL,NULL,NULL,NULL,'FAILED_CORRUPTED_MESSAGE','PULL','2017-09-20 18:47:59.879000000',1,1,166)
INSERT INTO USSD_GW_CDRS VALUES('a3538125-e9da-4b44-aeef-8ea6345ee020',2,8,1,NULL,NULL,NULL,8,0,4,'9960639902','*519#',1,1,'111111',1,1,'222222',NULL,NULL,NULL,NULL,NULL,NULL,NULL,'FAILED_CORRUPTED_MESSAGE','PULL','2017-09-20 18:48:20.728000000',2,2,27)
INSERT INTO USSD_GW_CDRS VALUES('4922e5fa-55e1-4a61-a6b7-0fd13dbe2ff7',2,8,1,NULL,NULL,NULL,8,0,4,'9960639902','*519#',1,1,'111111',1,1,'222222',NULL,NULL,NULL,NULL,NULL,NULL,NULL,'SUCCESS','PULL','2017-09-20 18:50:10.997000000',3,3,3957)
INSERT INTO USSD_GW_CDRS VALUES('ee93ec95-0131-41d2-9389-bd519475b8d5',2,8,1,NULL,NULL,NULL,8,0,4,'9960639902','*519#',1,1,'111111',1,1,'222222',NULL,NULL,NULL,NULL,NULL,NULL,NULL,'FAILED_INVOKE_TIMEOUT','PULL','2017-09-20 18:53:26.537000000',4,4,25045)

We can see the last column is the duration in milliseconds, with the last one timing out at 25secs

abdulazizali77 commented 6 years ago

@vetss Sergey, please have a look. Have added #76 changes

vetss commented 6 years ago

Hello @abdulazizali77

I have added your PR into master branch, thanks for your work. I will add comments into https://github.com/RestComm/ussdgateway/issues/76 , please check it.