Open abdulazizali77 opened 6 years ago
Hello @abdulazizali77
I checked your PR. Comments:
I have not added the new DB options to shell executor as i think it shouldnt be modifiable during runtime. What do you think?
Such options may be modifyable during runtime for usage in the next start. We need to mention it in the manual.
Do you think we should populate the dbLogin dbPass in UssdProperties.xml or should we fetch it from the *-ds.xml? (not sure how to do that yet)
Login and pass - we can include it into an xml file. "*-ds.xml" is also an option but it may take efforts, not sure this is really needed.
@vetss Sergey please have a look -I have not added the new DB options to shell executor as i think it shouldnt be modifiable during runtime. What do you think? -Do you think we should populate the
dbLogin
dbPass
inUssdProperties.xml
or should we fetch it from the*-ds.xml
? (not sure how to do that yet)