search

Restioson / xtra

🎭 A tiny actor framework
Mozilla Public License 2.0
321 stars 36 forks source link

Fix clippy warnings #208

Closed thomaseizinger closed 1 year ago

thomaseizinger commented 1 year ago

This fixes several clippy warnings that seem to have been added since we last worked on this. One of them flagged unused mutable references. As it turns out, Mailbox has complete interior mutability, meaning we don't actually need the mutable reference in many places.

thomaseizinger commented 1 year ago

Happy to merge once passes formatting

I forgot that we have a custom formatting command :D

thomaseizinger commented 1 year ago

@Restioson In an attempt to fix a failing test, I committed the lockfile as well. That is the new recommended policy for Rust: https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html

Restioson commented 1 year ago

Sounds good :)

thomaseizinger commented 1 year ago

Seems to pass now!

Restioson commented 1 year ago

Still seems to fail 1.60 --no-default-features :see_no_evil:

thomaseizinger commented 1 year ago

Still seems to fail 1.60 --no-default-features 🙈

Yeah because the lint was unknown :roll_eyes: Should actually be fixed now!

thomaseizinger commented 1 year ago

FFS.

thomaseizinger commented 1 year ago

@Restioson It is green!