Install script is wrong in egg file

RestoreMonarchy / pterodactyl-valheim

1 stars 2 forks source link

Install script is wrong in egg file #4

Closed lilmayu closed 3 years ago

lilmayu commented 3 years ago

In commit f058c7d6876fc251aef6dac955258360deb8e767 there is change in JSON egg - in "script" section. In there, there is just code for start_server.sh, not an actual install script for a pterodactyl. It will cause the container to just freeze in the "Install" phase and nothing will happen.

Simple workaround is to use JSON egg from commit 6f2990bc866af0524a5a6e126dad701f9cd4ba43 with start_server.sh from https://github.com/RestoreMonarchy/pterodactyl-valheim/pull/2 and it works perfectly.

RestoreMonarchy commented 3 years ago

Can you make a pull request?

lilmayu commented 3 years ago

Done, https://github.com/RestoreMonarchy/pterodactyl-valheim/pull/6

RestoreMonarchy commented 3 years ago

Thanks