Restream / redmine_tagging

Add simple tagging support to Redmine Issues/Wiki pages
113 stars 52 forks source link

Defect. Removing tag from wiki page not remove tag from tagcloud #12

Closed dany52 closed 13 years ago

dany52 commented 13 years ago

to reproduce

  1. add NEW tag to wiki page
  2. save wiki page
  3. delete tag from wiki page
  4. save wiki page

and see tagcloud not changed

maybe due to wiki history

retorquere commented 13 years ago

I can't reproduce this using latest from github. I do this:

Create a page "Tagged" Add tag "tag1" and save. Tag1 shows up in tagcloud Add new tag "tag5" and save. Tag5 shows up in tagcloud Remove "tag5" and save. Tag5 disappears from tagcloud

Does the tag return any search results when clicked on?

dany52 commented 13 years ago

Update plugin from github. Defect still exists.

"Does the tag return any search results when clicked on?" Yes

Another scenario to reproduce

  1. add NEW tag "tag1" to wiki page
  2. save wiki page
  3. delete tag from wiki page
  4. save wiki page

and see "tag1" still exists in tagcloud

then

  1. add NEW tag "tag2" to wiki page
  2. save wiki page

and see "tag1" renamed to "tag2" in tagcloud

retorquere commented 13 years ago

It's specific to in-line editing. I'll have a look later.

retorquere commented 13 years ago

I've added a note about this to the README:

Inline tagging using {{tag(bla bla)}} saves your tags when the body is rendered. A nasty side-effect of this is that if you want to remove all tags from an object, you must add {{tag}} to the body to actually clear the tags. After it’s been rendered once, you can remove it from the body.

retorquere commented 13 years ago

.