search

Restuta / rcn.io

:bicyclist: Making bike racing in USA "a better place" or "great again"
https://rcn.io
MIT License
44 stars 18 forks source link

Fixed show/hide all text link on calendar page with no upcoming events #296

Closed graymur closed 6 years ago

graymur commented 6 years ago

Added .gitattributes

Now when past events are hidden title will say "No upcoming events from Today (...)":

bcb6370463

How to test

http://rcn-io-staging.herokuapp.com/calendars/usac-2017?past=visible

Restuta commented 6 years ago

Added .gitattributes

why?

Restuta commented 6 years ago

@graymur Thanks for the PR, I updated description to use inline image vs the link.

graymur commented 6 years ago

@Restuta

why?

So we don't have problems with line endings between MacOS/Win

Restuta commented 6 years ago

@graymur we shouldn't have any, your local git setup should have default setting text=auto it will convert line endings during checkout and before push.

https://help.github.com/articles/dealing-with-line-endings/

Restuta commented 6 years ago

fixes #294

Restuta commented 6 years ago

Test it out, great work, thanks a lot for the fix 👍 Idk what I was thinking when I added that check.

Restuta commented 6 years ago

We will have to fix the build though by fixing #298 since it can break production

graymur commented 6 years ago

Idk what I was thinking when I added that check.

Happens to the best of us)