search

Restuta / rcn.io

:bicyclist: Making bike racing in USA "a better place" or "great again"
https://rcn.io
MIT License
44 stars 18 forks source link

jQuery is not defined error on prod #304

Closed Restuta closed 6 years ago

Restuta commented 6 years ago
2017-10-23_1803

Looks like some recent changes introduced that, but not sure which ones. @graymur suspect upgrade from bower. jQuery should not be there, we don't use it anywhere.

Restuta commented 6 years ago

I see, with the migration to NPM it now pulls boostrap JS to our bundle:

2017-10-23_1845
Restuta commented 6 years ago

And it's because "dependencies" that are defined in corresponding package.json section are automatically pulled to vendor.js file in production config and now this include bootstrap.