search

ResultadosDigitais / matrix

#matrix is the online open-source workplace inspired in sococo.com for distributed teams to have the experience of work together each day, side-by-side. No matter where team members might be. Working in an online workplace is even more productive when people are feeling in the same space.
MIT License
901 stars 238 forks source link

Deployment of custom rooms to Heroku #226

Open sidneydemoraes opened 4 years ago

sidneydemoraes commented 4 years ago

Description

The Heroku button is great for a very quick PoC that shows us briefly what #Matrix can do but now I wanna make deepers tests with it. I tried deploying manually (with Heroku CLI) by following the variables.env file instructions and I just can't make it work with Heroku deploys. Neither docker build nor heroku container:push allow us to use the env_file at build. I tried editing docker-entrypoint.sh file to source the env_file at run time but with no success whatsoever.

I see there is an issue with instructions to add variables manually in Heroku dashboard but we should really have a way to setup things with code.

Steps to Reproduce

First Try

  1. Create variables.env file as per instructions.
  2. edit docker-entrypoint.sh file to source variables.env at runtime.
  3. Run heroku container:push web
  4. Run heroku container:release web
  5. If you run heroku logs --tail you'll see that the environment variables were not loaded. None of them.

Second Try

  1. Instead of creating variables.env, edit heroku.yml and add variables to setup > config
  2. Same results.

Expected Behavior

Current Behavior

Suggestion

juliemar commented 4 years ago

Hi, @sidneydemoraes Thanks for all the explanations.

Could you try to follow this Heroku Documentation. If Works feel free to Open a PR improving our documentation about this issue.