search

ResultadosDigitais / matrix

#matrix is the online open-source workplace inspired in sococo.com for distributed teams to have the experience of work together each day, side-by-side. No matter where team members might be. Working in an online workplace is even more productive when people are feeling in the same space.
MIT License
901 stars 238 forks source link

Play sound while invite dialog is shown #312

Closed joseantonnio closed 4 years ago

joseantonnio commented 4 years ago

When I'm with #matrix tab running in background, my coworkers always need to send me a Slack message with "hey! we're inviting you to a meeting inside the #matrix".

Almost every invite notification that I receive goes unnoticed. So it would be very good have an incoming call sound playing while invite dialog is shown (Skype or Slack like).

Description

Play a ringtone sound (something like this one) while invite dialog is shown to user. When the user cancel or accept the invite the sound stops playing.

Additional context

Offtopic: Here at my work we're using #matrix and it's working quite good. Probably I'll be here time to time with some new ideas or bugs. Hope I can help with some PRs too but React and Node aren't my cup of tea :laughing:

juliemar commented 4 years ago

Hi @joseantonnio this is a good idea. I'm looking some kind of sound that represents the #matrix movie. Do you have some suggestions?

joseantonnio commented 4 years ago

On the first movie, Neo receives a Nokia to get instructions from Morpheus when he is at work. It's not the Nokia default ringtone that plays but a generic one. Think would be a very nice choice.

Here's the scene: https://www.youtube.com/watch?v=Lweuy1X9Tcg

joseantonnio commented 4 years ago

After googled "nokia matrix ringtone" I found this: https://www.zedge.net/ringtone/de0436b6-69d9-32fe-b5af-8ffefd6b7645 :smiley:

phiter commented 4 years ago

@joseantonnio did you try my solution? It has been merged to develop branch.

If it works I think this issue can be closed :D

joseantonnio commented 4 years ago

@phiter works like a charm :+1:

Thank you! And I'm sorry for the late answer...