search

ResultadosDigitais / matrix

#matrix is the online open-source workplace inspired in sococo.com for distributed teams to have the experience of work together each day, side-by-side. No matter where team members might be. Working in an online workplace is even more productive when people are feeling in the same space.
MIT License
901 stars 238 forks source link

#343 ignore accents in search #344

Closed phiter closed 4 years ago

phiter commented 4 years ago

Description

Resolves #343

How to test?

  1. Have a user or room with an accent somewhere in the name (eg: José/Café)
  2. Search for their name without including an accent (jose)

Expected behavior

User should show up even if the search query doesn't include the accent.

Proof:

xxx

phiter commented 4 years ago

Excellent improvement! Direct, clean and very valuable 🥇

Do you mind creating some unit tests in reducers.test.js to address those cases described in the PR description?

Done!

phiter commented 4 years ago

Codeclimate hates me lol

megatroom commented 4 years ago

Codeclimate hates me lol

ahahhahahahah

I thought about making the same suggestion in my review, but found it meaningless given the change. But it seems that Codeclimate is more rigorous than me :rofl: