search

RetGal / Dayon

Dayon! - A cross-platform remote desktop assistance solution for your family and friends
https://retgal.github.io/Dayon/
GNU General Public License v3.0
146 stars 45 forks source link

Help Assistant spot/resolve possible reason for problems: app versions mismatch #108

Closed lammel-hub closed 4 months ago

lammel-hub commented 4 months ago

(Note: currently travelling w/o PC, so unable to take screenshot or test)

Is your feature request related to a problem? Please describe. When Assistant receives a call from Assisted, the hello message contains which OS Assisted is running on. This enables Assistant to display the relevant [boss] key after the user of Assistant has accepted to connect.

If there are problems connecting Assisted to Assistant due to incompatibility between versions of the two, it may be hard to identify without some help.

Describe the solution you'd like

  1. Hello message to also contain the version number of Assisted
  2. If the number is different from Assistant, then Assistant adds an extra sentence in the pop up window that is displayed for the Assistant user to accept the connection: "Note! Assisted is currently running a different version. If you experience problems, please ensure you are running the latest version and connect again with compatibility mode activated."

Describe alternatives you've considered

Additional context No need to check if a version is higher or lower, only if it is different, since the solution is always the same if version incompatibility causes any problems.

RetGal commented 4 months ago

In order to be able to assist an assisted by updating their installation, the assistant part of Dayon! aims to be as compatible as possible. If it's not compatible to allow even basic functions, it displays the following dialog when an outdated assisted tries to connect: grafik If the connection attempt fails before the assistant can read the assisted version, then it's very likely caused by the legacy certificates the assisted insists to use. In such cases this dialog will be displayed: grafik (which is not completely translated, because it would require a rather major refactoring of this section of the code)

lammel-hub commented 4 months ago

This is just as good as proposed, great solution! Let me know if you want a translation further down the road.