RetGal / Dayon

Dayon! - A cross-platform remote desktop assistance solution for your family and friends
https://retgal.github.io/Dayon/
GNU General Public License v3.0
146 stars 45 forks source link

Invalid keycode & connection reset when using different keyboard layouts #4

Closed wvdschel closed 7 years ago

wvdschel commented 7 years ago

When using a different keyboard layout, the connection gets interrupted and the assistee gets an error message when pressing certain keys.

Steps to reproduce:

  1. Assisted computer uses Azerty (Belgian dot) keyboard layout on Windows
  2. Assistant computer uses US English keyboard layout on Windows
  3. Try to type a colon (':')
RetGal commented 7 years ago

Thanks for your report. I'm going to investigate this as soon as I get to it.

RetGal commented 7 years ago

The connection is no longer reset when an invalid (=not mappable on the assisted keyboard layout) keycode is received. A warning with the hint to use the same input locale on both computers is displayed instead. This will be included in release 1.4.2, I'll most likely build and upload the binaries tomorrow.

wvdschel commented 7 years ago

Great, thanks!

On Wed, Feb 15, 2017 at 11:32 PM, RetGal notifications@github.com wrote:

The connection is no longer reset when an invalid (=not mappable on the assisted keyboard layout) keycode is received. A warning with the hint to use the same input locale on both computers is displayed instead. This will be included in release 1.4.2, I'll most likely build and upload the binaries tomorrow.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/RetGal/Dayon/issues/4#issuecomment-280161953, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEpADJfv2G5HCfzxo-c0C8c2Eij1frCks5rc3z5gaJpZM4L3_rO .