RetGal / Dayon

Dayon! - A cross-platform remote desktop assistance solution for your family and friends
https://retgal.github.io/Dayon/
GNU General Public License v3.0
146 stars 45 forks source link

"assistant" jar runs "assisted" #56

Closed hurzl closed 1 year ago

hurzl commented 1 year ago
> java -jar dayon_assistant.jar
[                main] [ INFO] (22:26:37.858) ============================================================================================
[                main] [ INFO] (22:26:37.871)                   awt.toolkit [sun.awt.X11.XToolkit]
[                main] [ INFO] (22:26:37.871)        dayon.application.name [dayon_assisted]
...
============================================================================================
[    AWT-EventQueue-0] [ INFO] (22:26:38.229) Assisted start
RetGal commented 1 year ago

@hurzl you're right, thanks for reporting! I replaced the assistant.jar with a new build with the following md5 sum: b9fde424a691ae128d39146f61ae72a7

leapfog commented 1 year ago

seems that happened again with both "v12.0.0" and "v12.0.1"

leapfog commented 1 year ago

And, if assistant.jar really is assisted.jar, why is assisted.jar four times as big as assistant.jar?

RetGal commented 1 year ago

@leapfog thank you for reporting this! I replaced the assistant.jar with a new build with the following md5 sum: 7a0bf87dbbb5e3b9ad1a4b75ab88bf2f

Both jars are capable of running both sides of the app (Assisted and Assistant), depending on the main-class being run: mpo.dayon.assisted.AssistedRunner or mpo.dayon.assistant.AssistantRunner. For convenience, as requested some time ago by @InventM4n, there are two distinct jars - so users can run them directly (java -jar assistant.jar) without having to pass the -cp mpo.dayon.assistant.AssistantRunner part.

Regarding the different file size: The "standalone" assisted.jar and assisted.exe contain parts of additional libraries jna and jna-platform. They are required to access the Windows-registry and are used on Windows clients only. (UAC-dialogs)

hurzl commented 1 year ago

Maybe it would be even more convenient to use a single jar with a simple command line argument?

RetGal commented 1 year ago

@hurzi Indeed, I'll integrate this into the next release: #65 Thank you for the suggestion!