RetGal / Dayon

Dayon! - A cross-platform remote desktop assistance solution for your family and friends
https://retgal.github.io/Dayon/
GNU General Public License v3.0
146 stars 45 forks source link

Identifies public IP wrongly #73

Closed lammel-hub closed 7 months ago

lammel-hub commented 7 months ago

Describe the bug I pay to have a fixed public IP from my ISP. When clicking in the Assistant's upper right corner to identify public IP automatically, it shows another value than my public IP. The value seems related to my ISPs DNS range (but this is beyond my competence).

To Reproduce Steps to reproduce the behavior:

  1. Ensure you have a fixed IP as an activated service from your ISP
  2. Go to 'Set up connecting IP address'
  3. Click on 'Receive me ( public )'
  4. The value received is 100.6x.xxx.xx [port] (the ISPs DNS server is 100.6x.x.xx, while my actual public IP is 185.1xx.xx.xx)

Expected behavior That step 3. Click on 'Receive me ( public )' produces the actual public IP

Screenshots n/a

Desktop (please complete the following information):

Additional context When I start the Assisted on another computer and select the correct public IP (and port) to connect with the Assistant it all works well, so it seems it is only if I try to retrieve the public IP or try to connect via access token they fail to connect.

RetGal commented 7 months ago

Ok, I suspect this is a bug in the WaifUPnP library. Could you please check if UPnP is active in your network? Under Settings > Network, do you see: a) UPnP disabled grafik or rather: b) UPnP enabled grafik

lammel-hub commented 7 months ago

When I check it confirms that UPnP is enabled, as in the English screenshot (nice Swedish screenshot 👍)

RetGal commented 7 months ago

Ok, thanks for checking - so the upcoming release won't rely anymore on WaifUPnP for detecting the assistants public IP.

And it will also be the first version with a Swedish user interface :)

lammel-hub commented 7 months ago

looking forward to it :)

RetGal commented 7 months ago

Fixed in the new release 13.0.1 also available in the ms store.