RetGal / Dayon

Dayon! - A cross-platform remote desktop assistance solution for your family and friends
https://retgal.github.io/Dayon/
GNU General Public License v3.0
146 stars 45 forks source link

Small improvement of "receiving connection" confirmation window #80

Closed lammel-hub closed 7 months ago

lammel-hub commented 7 months ago

Is your feature request related to a problem? Please describe. The fingerprint function is an elegant and effective way to prevent MTM attacks, but only if it is being used by the Assistant.

Describe the solution you'd like I would suggest to add "Make sure to validate the fingerprints for this session when you see the Assisted screen. This is to avoid any man-in-the-middle attack." to the pop up window that the Assistant gets when confirming to accept an incoming connection request.

The benefit is that there already is a window that needs confirmation and it may be seen as a non-intrusive "friendly reminder" at the beginning of a session.

Describe alternatives you've considered To place the same text in the top banner of the app.

Additional context n/a

RetGal commented 7 months ago

Good point, will add this right to the next release!

lammel-hub commented 7 months ago

Works well in Swedish localization, with the following small text correction needed:

"Var noga med att validera fingeravtrycken för denna session när du ser hjälptagares skärm. Detta är för att förhindra man-in-the-middle-attacker."

lammel-hub commented 7 months ago

If you would like to share all English text strings, I could make a translation to SE rather than machine translation. (Like you did with the Babylon.conf file)

RetGal commented 7 months ago

All localized texts visible in the assistant and the assisted user interfaces are read from the Babylon.properties

lammel-hub commented 7 months ago

Ah, OK. I am new to Github. Should I correct such things directly in the Babylon file, or download and upload it in UTF8 as I did the first time?

RetGal commented 7 months ago

Yes, if you are not familiar with Git, this would probably be the "easiest" solution :)

RetGal commented 7 months ago

Please do not be confused by the double backslashes - the Java properties files use a rather peculiar encoding!

lammel-hub commented 7 months ago

Will you set some sort of flag to let me know when babylon_sv.properties is updated, so that I may add translations as they may be needed?