search

RetGal / Dayon

Dayon! - A cross-platform remote desktop assistance solution for your family and friends
https://retgal.github.io/Dayon/
GNU General Public License v3.0
146 stars 45 forks source link

Error message for Assistant when Assisted ends the session #84

Closed lammel-hub closed 6 months ago

lammel-hub commented 7 months ago

Describe the bug If If assisted closes a running session, the assistant provides an error message in a pop up window that may be confusing.

To Reproduce Steps to reproduce the behavior:

  1. Start both apps
  2. Click on "end session" for assisted
  3. See error screen shot "The program has encountered a communication error [!]."

Expected behavior A pop up window stating "the session was ended by the assisted" rather than a warning/error message.

Screenshots image

Desktop (please complete the following information):

Additional context Great overall work on the localization in 13.0.1!

RetGal commented 7 months ago

Yes, the protocol has currently no way to signal the peer that the session shall be ended - so it simply closes it's sockets. This makes it impossible to distinguish between a communication error and an intentional termination.

RetGal commented 6 months ago

Extended the protocol to signal an intended connection termination to the peer. However, it will not display a notification nor an error message anymore. (part of the next release)

lammel-hub commented 6 months ago

Brilliant! A good step forward.