RetGal / Dayon

Dayon! - A cross-platform remote desktop assistance solution for your family and friends
https://retgal.github.io/Dayon/
GNU General Public License v3.0
146 stars 45 forks source link

minor issue: input format of Token #91

Closed lammel-hub closed 6 months ago

lammel-hub commented 6 months ago

Describe the bug Connecting by using a Token for a session instead of IP address and port is an elegant and simple approach. It seems the Token generated by Assistant always is 4 characters long and consists of numbers [0-9] and capitalized letters [A-Z]. However, when assisted enters a Token to initiate a session it allows for input of any characters, also outside valid ranges [0-9, A-Z] which generates an error message. This is a minor issue, but could be frustrating to an inexperienced or stressed assisted that may not immediately realize the difference or importance of typing the exact Token and could use the help.

To Reproduce Steps to reproduce the behavior:

  1. Assistant: Go to Context: Connection. Function: Generate Token (illustrative example: "R8HE")
  2. Assisted: Go to Context: Home. Function: Connect to Assistant
  3. Assisted: enter the Token generated by Assisted, but do not use capitals (illustrative example: "r8he")
  4. Response given by Assistant is "Invalid Token"

Expected behavior Context: Home

Screenshots

Desktop (please complete the following information):

Additional context The valid range of Tokens may be different.

RetGal commented 6 months ago

Good catch! As the tokens use an adaptive length, I'll simply convert the users input to UPPERCASE