RetGal / Dayon

Dayon! - A cross-platform remote desktop assistance solution for your family and friends
https://retgal.github.io/Dayon/
GNU General Public License v3.0
146 stars 45 forks source link

Set up IP: default address shown #95

Closed lammel-hub closed 6 months ago

lammel-hub commented 6 months ago

Is your feature request related to a problem? Please describe. In Assistant, the default IP shown in Function: Set up IP is 127.0.0.1. This localhost is not (to my knowledge) useful for most users.

Describe the solution you'd like Context: Connection Function: Set up IP

Describe alternatives you've considered There may be use cases where other IP is more relevant, but the most common case would be Public IP. Public IP is already the IP address communicated to the rendezvous server (RVS) when generating a Token, so it "makes sense".

Additional context n/a

RetGal commented 6 months ago

I agree, the local loopback address is of very little use! But as the assistant doesn't even have to know its own public IP-address if he chooses to use the token variant, it would be a waste of time and network traffic to obtain the public PI each time the assistant is started. So I decided to only show the "blank" network button by default - and only resolve the public IP if it's clicked.

lammel-hub commented 6 months ago

Good point! My only consideration would then be to put up "Set up IP" as default label for the function

RetGal commented 6 months ago

With the existing tooltip it looks like that: grafik

lammel-hub commented 6 months ago

perfect solution! I see it in the BBII release