RetailMeNot / SeleniumGridScaler

Selenium Grid auto scaling plugin utilizing AWS
GNU General Public License v2.0
28 stars 76 forks source link

allow multiple security groups to be used when creating instances #11

Closed ambirag closed 9 years ago

ambirag commented 9 years ago

this change allows multiple security groups to be passed in aws.properties like this us-west-2_security_group=sg-a7a342c8,sg-afa542c0,sg-cce342a3 Without this change if multiple security group is passed, it throws the error "Error trying to start nodes: com.amazonaws.AmazonServiceException: The parameter groupName cannot be used with the parameter subnet (Service: AmazonEC2; Status Code: 400; Error Code: InvalidParameterCombination"

mhardin commented 9 years ago

I added a code review comment to the commit. Also, can we add a unit test to cover this case if its not covered already? Thanks.

ambirag commented 9 years ago

thanks @mhardin can you check now please!

mhardin commented 9 years ago

Commit looks good. Did you see my comment about adding a unit test to cover this case?

ambirag commented 9 years ago

i'll add unit test and let you know!

ambirag commented 9 years ago

@mhardin i have added a unit test for multiple group security group

ambirag commented 9 years ago

@mhardin can you check this pls ?

mhardin commented 9 years ago

Merged