search

RetailMeNotSandbox / ecs-selenium

Deploy Selenium Grid on Spot instances with Amazon ECS
MIT License
69 stars 27 forks source link

Makefile and configuration #17

Closed piotrplenik closed 6 years ago

piotrplenik commented 6 years ago

Simplify commands, by implementing global Configuration file and simple Makefiles for create/update stack, ECR login, ECR create nodes and update the desired count.

And at least: updated: Readme.md.

Hope you enjoy, If you have any comments, please let me know.

piotrplenik commented 6 years ago

Hi @rrivera-rmn, I see that my change works stable. Any comments/notices on my PR?

rrivera-rmn commented 6 years ago

@jupeter, found a make task that was misnamed. Other than that it looks good.

Thanks!

piotrplenik commented 6 years ago

@rrivera-rmn, thanks for a reply. Where exactly?

rrivera-rmn commented 6 years ago

@jupeter sorry. I could have sworn I made a comment inline, but it's not showing up:

# create the Firefox ECR repository
make ecr-create-firefox-node

# create the Chrome ECR repository
make ecr-create-firefox-node   # this should be chrome
piotrplenik commented 6 years ago

Thank you - now see. Updated!