search

Retera / WarsmashModEngine

An emulation engine to improve Warcraft III modding
GNU Affero General Public License v3.0
255 stars 45 forks source link

Refactor most of native functions' anonymous classes into lambdas. #28

Closed bearU369 closed 1 year ago

bearU369 commented 1 year ago

There isn't much performance benefits over lambdas as far as testing, other than makes the code at least shorter and concise to understand/build with. Some anonymous classes aren't replaced because they have their own class variables within which I don't want to mess with.

Retera commented 1 year ago

It appears I was too late merging this and it got slightly behind. Is it easy to update it to resolve whatever the merge conflict that GitHub is complaining about is now?

bearU369 commented 1 year ago

It appears I was too late merging this and it got slightly behind. Is it easy to update it to resolve whatever the merge conflict that GitHub is complaining about is now?

Yeah, I'll resolve the typos and errors in this PR.

Retera commented 1 year ago

Thanks! Going to merge this