Closed bearU369 closed 1 year ago
Hey, this is cool! Sorry I didn't investigate merging sooner.
What's the design concept behind passing in the Element terrainTileInfo
instead of just boolean buildable
to the constructor of the GroundTexture? Both are equally valid I would figure, but I wonder if simply passing in the boolean would be more open-ended for imaginary future use cases of GroundTexture
(which, to be fair, might never happen, for example if the current use case is the only one needed).
Hey, this is cool! Sorry I didn't investigate merging sooner.
What's the design concept behind passing in the
Element terrainTileInfo
instead of justboolean buildable
to the constructor of the GroundTexture? Both are equally valid I would figure, but I wonder if simply passing in the boolean would be more open-ended for imaginary future use cases ofGroundTexture
(which, to be fair, might never happen, for example if the current use case is the only one needed).
It's done so just in case in the future, multiple flags might be utilized as expanding the constructor for said flags might be tedious so I thought passing the Element and process them inside would save enough headache.
Okay, sounds logical enough. Merged!
Bugfix is done by utilizing the buildable flag exist in the
TerrainArt/Terrain.slk
forsetBlight
to check.Thanks to @Retera for pointing out the right direction.