Retera / WarsmashModEngine

An emulation engine to improve Warcraft III modding
GNU Affero General Public License v3.0
255 stars 45 forks source link

Bugfix to #32: Blight Growth can blight through unbuildable terrain #51

Closed bearU369 closed 1 year ago

bearU369 commented 1 year ago

Bugfix is done by utilizing the buildable flag exist in the TerrainArt/Terrain.slk for setBlight to check.

Thanks to @Retera for pointing out the right direction.

Retera commented 1 year ago

Hey, this is cool! Sorry I didn't investigate merging sooner.

What's the design concept behind passing in the Element terrainTileInfoinstead of just boolean buildable to the constructor of the GroundTexture? Both are equally valid I would figure, but I wonder if simply passing in the boolean would be more open-ended for imaginary future use cases of GroundTexture (which, to be fair, might never happen, for example if the current use case is the only one needed).

bearU369 commented 1 year ago

Hey, this is cool! Sorry I didn't investigate merging sooner.

What's the design concept behind passing in the Element terrainTileInfoinstead of just boolean buildable to the constructor of the GroundTexture? Both are equally valid I would figure, but I wonder if simply passing in the boolean would be more open-ended for imaginary future use cases of GroundTexture (which, to be fair, might never happen, for example if the current use case is the only one needed).

It's done so just in case in the future, multiple flags might be utilized as expanding the constructor for said flags might be tedious so I thought passing the Element and process them inside would save enough headache.

Retera commented 1 year ago

Okay, sounds logical enough. Merged!