search

RetherSzu / valorant-daily-shop

Access the latest updates on Valorant's daily store offers, available bundles and night market items, without having to log into the game.
MIT License
3 stars 2 forks source link

Multi language support request + Get region error #1

Closed scottjsh closed 6 months ago

scottjsh commented 6 months ago

Your source code is so neat and good. And I want to contribute on you project. How about add multi language support? I can add Korean.

scottjsh commented 6 months ago

Plus I cannot find expo/tsconfig.base

scottjsh commented 6 months ago

One more, I can't login with your app.

My Valorant region is KR.

==Device INFO== Android 12 SM-G973N

https://github.com/RetherSzu/valorant-daily-shop/assets/62782800/728a3954-3722-4aee-8155-a109a71967b2

scottjsh commented 6 months ago

When I debug the app, pd.an.a.pvp.net appers. My account region is KR. I think there's some problem on /userinfo

RetherSzu commented 6 months ago

Hello @scottjsh,

Thank you for your feedback and for pointing out this issue.

It appears that the problem was caused by my oversight in not retrieving the region information from a previous request. I've implemented a fix for this in the latest commit.

However, I haven't been able to test the fix myself yet. I would appreciate it if you could download the updated version of the app from the link below and see if it resolves the issue on your end. Here is the link to the application with the applied fix:

Download the updated app here

Please let me know if you encounter any further problems or if there's anything else I can assist with.

Thanks again for your help in improving the app!

scottjsh commented 6 months ago

Thank you for your reply.

App works nicely. But skin name is too small.

RetherSzu commented 6 months ago

Thanks for your feedback! I'll try to enlarge the skin name so it's more visible. I appreciate your contribution!

scottjsh commented 6 months ago

I'm talking about the "oni" part of "oni phantom". please refer to this.