search

RethinkRobotics-opensource / gennodejs

ROS JavaScript message definition and serialization generators
Apache License 2.0
7 stars 21 forks source link

Fix UTF-8 serialization #19

Closed mvollrath closed 5 years ago

mvollrath commented 5 years ago

This is #17 with the requested review fix to use _getByteLength() instead of the Buffer interface.

Fixes #18

chris-smith commented 5 years ago

Looking at this again, I think we need to add the same fix here for string arrays

mvollrath commented 5 years ago

You're right, that's where it does arrays of strings.