RethinkRobotics-opensource / gennodejs

ROS JavaScript message definition and serialization generators
Apache License 2.0
7 stars 21 forks source link

Update genjs for install #2

Closed chris-smith closed 8 years ago

chris-smith commented 8 years ago

-No longer includes hardcoded paths in generated message files -Some clean up -Bools are bools -Actually install stuff

IanTheEngineer commented 8 years ago

+1 great improvement, Chris. Can you elaborate on the install space improvement? Is verification as simple as running catkin_make install?

chris-smith commented 8 years ago

Yep - install should work now. Any message dependencies from other packages are found by searching your CMAKE_PREFIX_PATH. This unfortunately tethers you more to the ROS environment, but should be more robust. In your install/devel space by default you can find the generated code at share/node_js.

This directory will look like

This structure should exist across any workspaces in your chain, though the specific message packages will differ.

Can you open a feature request ticket for this for us to keep track of?

I also just opened a pull-request against rosjs that adds a script to flatten the directory structure and update your require paths. I can open a ticket here though too if we want to keep thinking about that. RethinkRobotics-opensource/rosjs#5