search

Retro-Arena / RetroPie-Setup

Shell script to set up a Raspberry Pi/Odroid/PC with RetroArch emulator and various cores
Other
3 stars 2 forks source link

retropie-mount propagate folders #33

Closed NeonLightning closed 5 years ago

NeonLightning commented 5 years ago

when given a filled retropie-mount folder it works as planned. when given a blank retropie-mount folder it is left blank

blisstik commented 5 years ago

Can you elaborate on expected behavior and actual behavior? I don't use this feature but need a way to replicate it.

NeonLightning commented 5 years ago

it should fill retropie-mount with a folder named "roms" and inside that should duplicate the folder and file structure of the the folder /home/pigaming/RetroPie/roms on the sdcard. and well it doesn't any of that.

if however you have a folder already propagated from a previous install on another retropie system it will read it as it should by linking(i'm not sure if it is linking or mounting) /media/usb0/retropie-mount/roms as /home/pigaming/RetroPie/roms

Jmanning6600 commented 5 years ago

I'm going to have a look at this right now. I can confirm The Issue Neon brings up I have tried multiple formats It looks like it sees the Retropie mount folder but it does not move folders over to it automatically.

blisstik commented 5 years ago

Looking at the code, it should rsync the files from SD to USB if retropie-mount/roms exist. It's mounting point is from roms now not retropie-mount.

Test this by creating retropie-mount and roms within the USB drive and see if it kicks off rsync.

From: Jmanning6600 notifications@github.com Sent: Sunday, December 30, 2018 7:51 PM To: Retro-Arena/RetroPie-Setup Cc: 6alileo; Comment Subject: Re: [Retro-Arena/RetroPie-Setup] retropie-mount propagate folders (#33)

I going to have a look at this right now.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/Retro-Arena/RetroPie-Setup/issues/33#issuecomment-450605532, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AoSfFPa3E99H27ylZf7D5XC94KdLJPqvks5u-YmkgaJpZM4ZlJ-j.

qbertaddict commented 5 years ago

my drive is already that folder structure /retropie-mount/roms/ and it is not kicking off

blisstik commented 5 years ago

The roms folder has to be empty

From: qbertaddict notifications@github.com Sent: Monday, December 31, 2018 6:43 AM To: Retro-Arena/RetroPie-Setup Cc: 6alileo; Comment Subject: Re: [Retro-Arena/RetroPie-Setup] retropie-mount propagate folders (#33)

my drive is already that folder structure /retropie-mount/roms/ and it is not kicking off

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/Retro-Arena/RetroPie-Setup/issues/33#issuecomment-450653361, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AoSfFBWyDT8S2ZNbfWv8bN7m-g0cLTvYks5u-iJ_gaJpZM4ZlJ-j.

NeonLightning commented 5 years ago

yes that was the problem

blisstik commented 5 years ago

Is the expected behavior for roms from SD card to rsync regardless if its empty or not? The way it was coded by RetroPie is only when the folder is empty. I'm also thinking about removing this since it doesn't have any checks for filesizes. It's possible the SD card could copy a larger set than the USB so its dumb in that regard.

NeonLightning commented 5 years ago

the expected is for there to be an empty folder called retropie-mount and when you insert it it copies all the stuff from your sd to your usb from ~/RetroPie/ i know we've switched to just roms. but having to create the roms folder is not the usual so it may confuse some people(like me until it was explained)

Jmanning6600 commented 5 years ago

I agree with Neon.

On Mon, Dec 31, 2018, 12:51 PM NeonLightning <notifications@github.com wrote:

the expected is for there to be an empty folder called retropie-mount and when you insert it it copies all the stuff from your sd to your usb from ~/RetroPie/ i know we've switched to just roms. but having to create the roms folder is not the usual so it may confuse some people(like me until it was explained)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Retro-Arena/RetroPie-Setup/issues/33#issuecomment-450674280, or mute the thread https://github.com/notifications/unsubscribe-auth/Ajn8AW4q6s9fel5XpAjpFZVAYLSldlKnks5u-k6-gaJpZM4ZlJ-j .

blisstik commented 5 years ago

The original retropie-mount was designed to copy all of the SD /home/pigaming/RetroPie folder structure to the USB drive retropie-mount folder, including the BIOS folder.

The BIOS folder in the USB drive causes an issue with lr-reicast Atomiswave and Naomi booting the roms. The BIOS folder must remain in the SD card since it has full write access.

The resolution was to only mount the retropie-mount/roms folder and in turn, as a side effect, the script now expects retropie-mount and roms folders to be created MANUALLY. The script checks a deeper folder so rsync can kick off.

When I did this, I decided to keep the same folder structure as retropie-mount using the same folder name and roms structure since all users will probably have the same structure already.

Since creating the retropie-mount and roms folder is a one time process, I don't see the need to modify the script further to accommodate the extra step of creating a roms folder in the USB drive.

What do you guys think? Should we just can the rsync portion of the script since manual copying will be a much better option.

NeonLightning commented 5 years ago

maybe a separate script from setup or ES that'll either copy your copy all of roms from sd to usb. or atleast a script that'll generate all the default folders? because if we don't have some sort of standardized folder naming scheme that people expect to follow then we'll likely encounter more support questions.

blisstik commented 5 years ago

Would you mind taking this on Neon? The rsync flags is in the link below. It's possible we can make this an option but you need checks for 1) usb drive is mounted and 2) folders exists, if not create then 3) rsync

https://github.com/Retro-Arena/RetroPie-Setup/blob/master/scriptmodules/supplementary/usbromservice/10_retropie_mount#L54

From: NeonLightning notifications@github.com Sent: Monday, December 31, 2018 11:10 AM To: Retro-Arena/RetroPie-Setup Cc: 6alileo; Comment Subject: Re: [Retro-Arena/RetroPie-Setup] retropie-mount propagate folders (#33)

maybe a separate script from setup or ES that'll either copy your copy all of roms from sd to usb. or atleast a script that'll generate all the default folders? because if we don't have some sort of standardized folder naming scheme that people expect to follow then we'll likely encounter more support questions.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/Retro-Arena/RetroPie-Setup/issues/33#issuecomment-450681547, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AoSfFHTLv14d6IGg2LLg7PLVEFPqunB6ks5u-mEsgaJpZM4ZlJ-j.