RetroAchievements / RABot

RetroAchievements.org's Discord Bot
GNU General Public License v3.0
9 stars 6 forks source link

created mod setaotw and removeaotw commands #53

Open zapobyte opened 4 years ago

zapobyte commented 4 years ago

created 2 commands for aotw role managment

To check if the user giving the right role and if he has the right role to perform the actions I have added in the .env config files 2 variables:ROLE_MOD_NAMEand AOTW_ROLE_ID which are used in both commands. ROLE_MOD_NAME hold the name of the role mod('mod' example) AOTW_ROLE_ID is the id of the role('667583344573284384' example

meleu commented 4 years ago

Yo, thanks!

It's being a busy week here. Will try to review/test this on the next weekend.

meleu commented 4 years ago

hey @vzapo lemme share with you how the AotW thing works on our discord server.

That being said, what I thought to make mods life easier is:

(in other words, a command to remove the role from individuals would not be that necessary)

zapobyte commented 4 years ago

ahh i see. might help something like this:

meleu commented 4 years ago

as an addition i could create a function that would run weekly and auto remove aotw roll from all the users in the channel that had the role.

There's no need for this, cause the "AotW renovation" is manually handled by the AotW maintainers (currently @ikki5 and Flara). Although they try to attend a schedule, they also have RL commitments.

Then I prefer to not make RABot do things automatically in a very specific time. It would create a false impression to the players community that the AotW maintainers must meet the RABot's schedule (and, well, we are all volunteers here...).

zapobyte commented 4 years ago

Yeah, you're right. I did not think of that, just wanted to help their work a bit :) Thought it would be easier for them not to remove it manually since they have to credit manually. I'll work on the rest of necessary adjustments then.

zapobyte commented 4 years ago

Hey guys, think this is ready for review now. I've ended up with this workflow:

meleu commented 4 years ago

I've made some changes in the setaotw.js, but now I need to go to bed.

Later I'll review the removeaotw.js

Thanks!