search

RetroAchievements / RAIntegration

The DLL responsible to integrate emulators with RetroAchievements.org
https://retroachievements.org
MIT License
98 stars 23 forks source link

Add shift-click feature on memory view to put focus on pointed address #1083

Open Vancleeff opened 7 months ago

Vancleeff commented 7 months ago

Enhanced user experience by providing a convenient way to navigate to specific pointed memory addresses

Vancleeff commented 7 months ago

Thank you for the review @Jamiras, very helpful ! I made some correction and pushed everything, I'm not sure if the tests are enough for this usecase or if I need to add more console context.

Vancleeff commented 7 months ago

Thanks @Jamiras ! I changed the logic a bit by adding a mask for more complex pointer which are not converted into real addresses when using ByteAddressFromRealAddress.

Example : PSX pointer like 0x80012345 are now masked based on the pConsoleContext.MaxAddress size and then converted with ByteAddressFromRealAddress to point towards 0x12345 address.

I adapted the tests accordingly.

Jamiras commented 6 months ago

Are you still working on these? Three of the four PRs have CI failures that need to be addressed, and the fourth has open comments to resolve.

Vancleeff commented 6 months ago

Hello @Jamiras ! Yes, I had to finish my second set, it's now on pending review so I will switch back on these PRs !