RetroAchievements / RAIntegration

The DLL responsible to integrate emulators with RetroAchievements.org
https://retroachievements.org
MIT License
97 stars 23 forks source link

Fix bug where modifying conditions improperly hide the target value cell. #1112

Closed redwizard42 closed 3 months ago

redwizard42 commented 3 months ago

Selecting a modifying condition like Add Source, the Target Value will be hidden when you first change the operator away form 'None', until you change the Target Type. This was especially noticeable when pasting in something like Add Source Mem 0x1234 / Mem 0x1234, but also evident if you just created a new condition and immediately changed the flag to Add Source, followed by setting the operator.

OnValueChanged handler is updated to re-evaluate the HasTargetValuePropertly when the operator is changed.