RetroAchievements / RAIntegration

The DLL responsible to integrate emulators with RetroAchievements.org
https://retroachievements.org
MIT License
98 stars 23 forks source link

Memory Inspector Results Increase when searching for 4-bits #293

Closed ghost closed 5 years ago

ghost commented 5 years ago

The latest Toolkit version from 2019-02-01 has a issue where the number of results increase randomly when searching for 4-bits instead of always decreasing.

Results increase 4-bits

Tested and replicated it in following Emulators and RALibRetro Cores.

All of them are affected so i assume its a global issue and more if not all Emus/Cores are affected by it, it only happens when searching for 4-bits.

Keltron3030 commented 5 years ago

I thought that issue was resolved with https://github.com/RetroAchievements/RAIntegration/pull/210

Jamiras commented 5 years ago

That's clearly not the 2019-02-01 DLL. The "Game Memory" label is incorrect in the release candidate:

image

Due to this commit: https://github.com/RetroAchievements/RAIntegration/pull/161/files#diff-0312105b0da4a96ba5fec93bef1a22c6R1523

You are most likely experiencing the problem resolved in #210. I will however, correct the label.

ghost commented 5 years ago

The GIF above is from RAVBA 0.56 Toolkit 0.74, which always downloads the latest Toolkit version on startup, so for me its 2019-02-01.

I've deleted the Toolkit and redownloaded it and its still the exaxt same version 12414bcebe16602224762603ac8568f9. This is the Toolkit version i get when autoupdating it.

Jamiras commented 5 years ago

0.74 is the published toolkit, and the version that will be downloaded if you use the emulator.

image

The 0.75 builds are in the #developer-news channel on discord. The "release candidate" is 0.74.124.0:

image

To use a non-published version, you have to download it from discord and unzip it into your emulator directory.

Jamiras commented 5 years ago

So, while you may have downloaded it on 2019-02-01, it's the dll that was published on 2018-09-08, and does not include the fix made for #210.

Closing as duplicate of #210.