RetroAchievements / RAIntegration

The DLL responsible to integrate emulators with RetroAchievements.org
https://retroachievements.org
MIT License
98 stars 22 forks source link

prevent crash viewing tooltip for address chain after modification #851

Closed Jamiras closed 2 years ago

Jamiras commented 2 years ago

Ensures only one change event is raised when multiple properties of a condition change at the same time.

When changing a field from Value to a memory type, the size field is updated as well as the Type field. This generates two events for the trigger changing, but the serialized form did not actually change on the second event, leaving the backing data uninitialized. When trying to view the Indirect tooltip without backing data, the application would crash.