RetroAchievements / RAIntegration

The DLL responsible to integrate emulators with RetroAchievements.org
https://retroachievements.org
MIT License
98 stars 23 forks source link

use AddAddress chain for determining indirect tooltip in asset editor #932

Closed Jamiras closed 2 years ago

Jamiras commented 2 years ago

Fixes issue where indirect tooltips were not being shown in the achievement editor if the achievement logic only uses a portion of the pointer (i.e. 24-bit read on 32-bit pointer). If the note was annotated with "[32-bit pointer]", it would assign the indirect note to the real address, not the address associated to the RetroAchievements mapping.

This modifies the tooltip logic to use the AddAddress from the achievement definition to find the indirect tooltip. The actual note panel will not show the indirect note as it still assumes the note is associated to the real address.