Closed retroNUC closed 1 year ago
Looked into this myself. Something wrong with latest versions of libchdr?
Downgrading the submodule to an earlier version (same version that PCSX2 uses) fixes everything.
I've got a branch here where I downgraded libchdr to the same one as PCSX2, which fixes most issues:
I won't submit a PR on it, because the correct thing to do would probably be to open an issue over at libchdr then upgrade it once fixed. Do you mind being the one to do that?
I finally found a chd I could reproduce with. It seems like the problem was fixed here: https://github.com/rtissera/libchdr/commit/678434c447298e396d08d14bafd5e8793f123fbe
I'm going to look at upgrading to latest, as there's a couple other error-handling fixes since then.
This may be the case of the problems I reported over here - https://github.com/RetroAchievements/rcheevos/issues/225. After further discussion, LaunchBox wasn't integrating rcheevos library directly, but instead just bundling and calling rahasher.exe, then using the result.
May need to check/update the libchdr implementation? Did a quick check against retroarch implementation, and it did seem to be missing a few functions like the 'special track' detection.
Examples of some valid PS2 CHD files that can't be parsed through RAHasher:
7 Blades (Europe) (En,Fr,De) - No output
AND 1 Streetball (USA) (En,Fr,Es) (v2.00) - Error