search

RetroAchievements / rcheevos

Library to parse and evaluate achievements and leaderboards for RetroAchievements
MIT License
86 stars 33 forks source link

Add Gamecube to hash initialize iterator for iso format #353

Closed bozothegeek closed 2 weeks ago

bozothegeek commented 1 month ago

Just to add Gamecube now for 'iso' format in hash initialization for iterator. Thanks in advance for this merge. Tested in pixL (new retro OS ;-)

bozothegeek commented 1 month ago

See for example of result when hash matched well now with any new retroarchivements for gamecube in this OS using pegasus-frontend and a modified GameOS theme including RA display... image

Jamiras commented 1 month ago

Please also update the test_hash_gamecube function to initialize an iterator and validate the new code path.

Jamiras commented 1 month ago

@bozothegeek - have you had a chance to look at the unit test suggestion?

bozothegeek commented 1 month ago

@bozothegeek - have you had a chance to look at the unit test suggestion?

OK, I will check... sorry, I just saw your reply ;-)

bozothegeek commented 1 month ago

Hi @Jamiras It's done, I updated the unit test test_hash_gamecube as expected, thanks in advance

bozothegeek commented 1 week ago

@Jamiras Thanks ;-)