search

RetroAchievements / rcheevos

Library to parse and evaluate achievements and leaderboards for RetroAchievements
MIT License
90 stars 34 forks source link

Update consoleinfo.c for SA-1 Support #371

Closed wolfman2000 closed 4 days ago

wolfman2000 commented 1 month ago

Code suggestion by Souzooka. This has not been tested or verified. Maybe this works right out of the gate, maybe this doesn't. Just wanted this out there.

redwizard42 commented 1 month ago

You should go through and test to see if the mapping properly shows up at the very least.

wolfman2000 commented 1 month ago

I can do that when I get home. I was under a time crunch when I made the PR.

Jamiras commented 4 days ago

I think #375 is a better implementation for this. Since BW-RAM is already exposed as SRAM, expanding SRAM to support the maximum amount available (which is actually larger than the 256KB allowed by BW-RAM) maintains backwards compatibility with the any achievements already looking for BW-RAM there. Then the I-RAM can be appended after that.

Note that no cores currently expose more than 128KB of SRAM/BW-RAM, and none of them expose any I-RAM.

CasualPokePlayer commented 4 days ago

Note that no cores currently expose more than 128KB of SRAM/BW-RAM

To be clear, Snes9x libretro currently does have an internal limit of 512KiB, but there's a 128KiB limit placed in for exposing memory due to that being the old limit and libretro core not being updated (also likewise, upstream Snes9x would just produce 512KiB SRAM for whatever romhacks have that). It would be easy enough to fix that on their side.