search

RetroAchievements / rcheevos

Library to parse and evaluate achievements and leaderboards for RetroAchievements
MIT License
90 stars 34 forks source link

add game hash query param to patch api calls #384

Open wescopeland opened 4 days ago

wescopeland commented 4 days ago

Required for multiset.

wescopeland commented 4 days ago

Had a lot of trouble getting the tests to run on my ARM machine. This is a comment just to help anyone else in the future (or myself again) who may be in a similar boat.

To finally repro the failures occurring in CI, I created a Dockerfile at root with the following content:

FROM --platform=linux/amd64 ubuntu:latest

RUN apt-get update && \
    apt-get install -y gcc-multilib make

WORKDIR /rcheevos/test

CMD make clean && make BUILD=c89 test && ./test

Then to execute the tests:

docker run --platform=linux/amd64 -v "$(pwd):/rcheevos" -e ARCH=x86 rcheevos-test
Jamiras commented 4 days ago

Had a lot of trouble getting the tests to run on my ARM machine.

What sort of trouble? Was the makefile not running? Perhaps some of these changes might be applicable?

wescopeland commented 4 days ago

What sort of trouble? Was the makefile not running?

The makefile was indeed running, but I was experiencing something like these workflow runs: Screenshot 2024-11-13 at 7 19 35 PM

Locally, everything was passing similar to that one passing job. Then when I actually pushed, I was surprised to find so many things were failing. Only when I set up the Dockerfile locally could I repro those failures on my ARM machine.

wescopeland commented 4 days ago

This also could just stem from me having a very limited understanding of the rcheevos project. This was a big learning experience for me.