search

RetroKoH / S1Fixed

A successor to ReadySonic (Bugfixes, Optimizations, Changes)
10 stars 0 forks source link

Incorrect Timpani Pitches in SBZ #21

Closed RunninPigeon closed 3 weeks ago

RunninPigeon commented 1 month ago

The Timpani pitches in SBZ are opposite than masa's demo compared to vanilla sonic 1.

RetroKoH commented 3 weeks ago

Can you please test this with the MegaPCM addition build? (333519b) Does it happen with that build too? I can't really tell the exact difference.

RunninPigeon commented 3 weeks ago

Yes it does, it more of a less a music file DAC error (aka sound/music/Mus06 - SBZ.asm

RetroKoH commented 3 weeks ago

That's wild, because I don't remember ever editing that file (or any of them for that matter). I wonder if something is being read incorrectly by MegaPCM2? I'll come back to this one later.

RetroKoH commented 3 weeks ago

I am listening to this between Fixed and stock S1, along with ReadySonic, and a clean S1 with MegaPCM2 and they sound just about identical. I even had a few other modders give it a look/listen and they are reporting there is no issue. After further inspection, a possible reason has been found by Malachi:

Basically, megapcm2 has clean sample playback, but you're applying it to a game that originally didn't so even in the best cases it's gonna sound different

I will close this for now and consider slightly altering pitches later

RunninPigeon commented 3 weeks ago

According to Mastered Realm in a YouTube comment:

There are two timpanis (special kind of drum) in different in the percussion, and when compared to Masa's demo, the pitches are all inverted! For example, when the timpanis are Hi, Hi, Lo, Hi, they are 'Lo, Lo, Hi, Lo' in Sonic 1. So probably the Sonic 1 driver changed after this song was added, as all other songs with timpanis match the demo!

this could be solved by inverting the timpani pitches, simple as that! :)

RetroKoH commented 3 weeks ago

Ah... so you're saying there is an alternate version (based on the demo) that has inverted timpani pitches?

Perhaps this can be a minor elective mod.

RunninPigeon commented 3 weeks ago

Yeah, but that was the original version before it was transferred onto the Genesis/Mega Drive