RetroMusicPlayer / RetroMusicPlayer

Best Material You Design music player for Android
https://retromusic.app
GNU General Public License v3.0
4.02k stars 759 forks source link

App keeps corrupting my music when changing tags #1447

Open ExperiencersInternational opened 1 year ago

ExperiencersInternational commented 1 year ago

Have you read the FAQ? [Yes]

Has the bug already been reported? Please search in GitHub issue tab before creating an issue. [No]

Describe the bug The application keeps corrupting my music, specifically 2 tracks, but I have a general issue with this being unreliable to edit tags anyways with it not processing.

How To Reproduce Steps to reproduce the behavior:

  1. Download the affected tracks from these specific URLs: https://mp3.chauthanh.info/soundtracks/nintendo-eshop-original-soundtrack-2011-2017/tnbutgkpgi/23.%20May%202019%20%283DS%20Wii%20U%29.mp3 and https://mp3.chauthanh.info/soundtracks/nintendo-eshop-original-soundtrack-2011-2017/kfvwheaklf/16.%20July%202014%20%283DS%20Wii%20U%29.mp3
  2. Open them in Retro Music, you'll find they'll play normally
  3. Try editing the tags of the album they're both in
  4. Music is now corrupted

If this is related, those are both my first and last soundtracks in my album

Expected behavior I expect this to change the tags in the entire album, without corrupting everything.

Screenshots Screenshot_2023-01-21-17-56-34-399-edit_com mi android globalFileexplorer Screenshot_2023-01-21-17-56-23-486_com mi android globalFileexplorer Screenshot_2023-01-21-17-56-09-240_code name monkey retromusic

Device info:

Additional context Add any other context about the problem here.

prathameshmm02 commented 1 year ago

I can reproduce the bug, thanks for reporting. It's mostly related to file formats these ones are MPEG-2 and MPEG-2.5, I have mostly MPEG-1 songs in my library. I'll try to fix this bug ASAP. Till then you can use autotagger.

prathameshmm02 commented 1 year ago

We use JAudioTagger library for editing the tags of songs, looks like either that library doesn't support this file format or there's something wrong with the music files. I even tried with Auto tagger which probably uses the same library, it doesn't work in that too. For now the best I can do is restrict the user from editing the tags of such songs.