search

RetroPie / EmulationStation

A Fork of Emulation Station for RetroPie. Emulation Station is a flexible emulator front-end supporting keyboardless navigation and custom system themes.
Other
856 stars 344 forks source link

Zoom in transition on game launch is now broken #151

Closed pjft closed 7 years ago

pjft commented 7 years ago

Just bisected it, and narrowed it down to this commit:

commit de643bb1140d75b6a8605f79866c4f1f2a7340e3
Author: jrassa
Date:   Tue May 30 22:41:41 2017 -0400

    use clip rects to prevent views overflow onto other views

@jrassa - any thoughts on this?

If I comment out the clip rectangles on the IGameList.cpp file, it works as previously, but I suspect that defeats the purpose of this particular change?

From what I gather, it seems that the rectangle clipping is not using the right (potentially moving) center for the zoom in animation and respective clipping.

Would love your perspective here, as I don't want to break whatever you did.

Thanks!

joolswills commented 7 years ago

@pjft Thanks.

jrassa commented 7 years ago

@pjft I am looking into a fix.

jrassa commented 7 years ago

@pjft The way the zoom animation works is that it draws the view progressively larger. The previous change that I made did not account for this, so as the view became larger, the clip rect stayed the same size which caused it to only draw a progressively smaller portion of the view. I was able to extract the current scale factor from the transform and apply it to the clip rect.

pjft commented 7 years ago

Great - glad it was an easy-ish fix for you! :)

On Fri, Jun 2, 2017 at 6:38 AM, Jools Wills notifications@github.com wrote:

Closed #151 https://github.com/RetroPie/EmulationStation/issues/151 via b3181a2 https://github.com/RetroPie/EmulationStation/commit/b3181a2c090f10a3702445d2f9b134dd1d0d0d91 .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/RetroPie/EmulationStation/issues/151#event-1107223708, or mute the thread https://github.com/notifications/unsubscribe-auth/AVAV7Q3l3qRz5iFdlxeJ4zi56gA4O98Eks5r_5_QgaJpZM4NtCN3 .