search

RetroPie / EmulationStation

A Fork of Emulation Station for RetroPie. Emulation Station is a flexible emulator front-end supporting keyboardless navigation and custom system themes.
Other
858 stars 344 forks source link

Scraping Failure: NES/SNES #312

Closed darklightindigo closed 6 years ago

darklightindigo commented 6 years ago

Received multiple reports on TGDB forums that scraping NES and SNES titles returns no results. Tracked back to apparent regression during boost cleanup 2-3 weeks ago.

https://github.com/RetroPie/EmulationStation/blob/master/es-app/src/scrapers/GamesDBScraper.cpp

It can’t be a coincidence that lines 40 and 66 used curly brace openers instead of open-parentheses for the acronyms: 40 { NINTENDO_ENTERTAINMENT_SYSTEM, “Nintendo Entertainment System { NES)” }, … 66 { SUPER_NINTENDO, “Super Nintendo { SNES)” },

To correctly parse the strings, line 40 should be { NINTENDO_ENTERTAINMENT_SYSTEM, “Nintendo Entertainment System (NES)” },

Whereas line 66 should be { SUPER_NINTENDO, “Super Nintendo (SNES)” },

tomaz82 commented 6 years ago

Good find! I'll fix it right away.

tomaz82 commented 6 years ago

https://github.com/RetroPie/EmulationStation/pull/313

darklightindigo commented 6 years ago

Thank you! Everyone at TGDB will be happy to hear this. :smile: http://forums.thegamesdb.net/topic/290/nes-and-snes-games-not-scraping-the-games-db-scraper/37 (In case you'd like to take a bow. :wink:)