RetroPie / EmulationStation

A Fork of Emulation Station for RetroPie. Emulation Station is a flexible emulator front-end supporting keyboardless navigation and custom system themes.
Other
863 stars 344 forks source link

RPI support: split omxplayer build option #792

Closed cmitu closed 2 years ago

cmitu commented 2 years ago

Modified the build options and source files to enable omxplayer for video previews only when the OMX option is used. Updated the build instructions on RPI accordingly and added some notes about the deprecation of the BRCM GPU drivers in RasPI OS 'Bullseye'.

Previously, the RPI build option would be used to add both RPI specific audio settings/VRAM limits AND add omxplayer support. However, omxplayer does not work with the RPI KMS video driver (vc4-kms-v3d) or with a 64bit RPI system, due to the lack of OpenMAX (OMX) API support. The new RasPi OS ('bullseye') has made the KMS driver the default [1] and doesn't offer omxplayer anymore (considered deprecated [2]).

Splitting the OMX support from the RPI option allows to set some default values for RPI systems without automatically adding the omxplayer bits.

[1] https://www.raspberrypi.com/news/raspberry-pi-os-debian-bullseye/ [2] https://github.com/popcornmix/omxplayer/commit/1f1d0ccd65

For RetroPie, we'll have to adjust the build options accordingly for the package(s).

joolswills commented 2 years ago

Thanks.