search

RetroPie / EmulationStation

A Fork of Emulation Station for RetroPie. Emulation Station is a flexible emulator front-end supporting keyboardless navigation and custom system themes.
Other
858 stars 344 forks source link

Replace load with load_buffer in ScreenScraper #837

Closed Bit-Sage closed 8 months ago

Bit-Sage commented 10 months ago

Updated ScreenScraper.cpp to replace deprecated pugi::xml_document::load method with load_buffer for XML parsing, aligning with current pugixml API standards.

pjft commented 9 months ago

Thanks for this. As it stands, it doesn't really compile on the Pi though.

/home/pi/RetroPie-Setup/tmp/build/emulationstation-dev/es-app/src/scrapers/ScreenScraper.cpp:188:62: error: 'getContent' was not declared in this scope; did you mean 'content'?
  188 |         pugi::xml_parse_result parseResult = doc.load_buffer(getContent(), content.size());
      |                                                              ^~~~~~~~~~
      |                                                              content
make[2]: *** [es-app/CMakeFiles/emulationstation.dir/build.make:538: es-app/CMakeFiles/emulationstation.dir/src/scrapers/ScreenScraper.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:1008: es-app/CMakeFiles/emulationstation.dir/all] Error 2

Could you look into it?

pjft commented 8 months ago

This was solved in #843