Changes to maintain and persist <folder/> information in a gamelist:

[Gemba]

1. folder elements are loaded when present in a gamelist and if they match the filesystem representation
2. missing optional folder elements are rendered empty in theme (and not "unknown")
3. As before non-existing folder elements are generated by ES, with mandatory elements <path/> and <name/>, but with this PR, whenever metadata is edited for this folder object (FileData class) it is persisted
4. Editiing metadata on existing <folder/> gets persisted too
5. UI metadata edit: layout fix that renders entered metadata not centered when returning from editing
6. UI metadata edit: format tooltip for date format in release date field

[Gemba]

As it involved several files I will comment on the crucial changes.

[pjft]

@Gemba pinging this, in case you were waiting for me to make progress here. I am ok with the changes, just had the couple minor questions I added there. No pressure though - just wanted to make sure this wasn't in a limbo because of me. Have a great weekend.

[Gemba]

Thanks. I have read through this issue twice. Did I miss a question to answer? I you can recap the one(s) which escaped my attention it would be nice.

[pjft]

Sure. Main questions I had:

• Gamelist.cpp: std::string relative = Utils::FileSystem::removeCommonPath(path, root->getPath(), contains, true); - root->getPath() should be systempath, or am I missing something?
• Why don't we allow ratings for the folders?

[Gemba]

* Gamelist.cpp: std::string relative = Utils::FileSystem::removeCommonPath(path, root->getPath(), contains, true); - root->getPath() should be systempath, or am I missing something?

You are right. Well spotted. Done.

* Why don't we allow ratings for the folders?

It was more an assumption of mine. I don't stick to that. Enabled the rating edit on folders. Thanks for nudging me.

[pjft]

Thanks. I just tested this and, from what I was able to test on my end, I'm good with merging. Just a minor question I asked regarding a label, but I'm good to go next. I don't have folders on my setup, though, so it should be test run by more in the community if you can share it there!

[Gemba]

Will ask for more testers in the forum. Just let me know: Before the merge or after the merge?

[pjft]

Afterwards is fine, it's just to make sure the different scenarios get covered.

Do check my comment on the variable and squash as appropriate. Let me know when it's good to go.

[Gemba]

Afterwards is fine, it's just to make sure the different scenarios get covered.

Ok.

Do check my comment on the variable and squash as appropriate. Let me know when it's good to go.

I sure will. But I am really sorry to bother you again, I cannot spot your comment on the label/variable. Would you be so kind to highlight/repeat it? Thanks.

[pjft]

GuiMetaDataEd.cpp:41 - why ROM and not GAME?

[Gemba]

GuiMetaDataEd.cpp:41 - why ROM and not GAME?

Ah. Thanks. I put "ROM" here deliberatly as the filename with extension will be shown. The ROM's display title is shown first in the edit fields.

[pjft]

If I'm reading this correctly, then we should probably keep GAME for a few reasons:

• The ROM's display title shows up as "NAME", it doesn't mention ROM anywhere on the screen.
• That's a new concept for the end user, as we never refer to the games as ROMs (searching the code will only yield one public instance of "ROM" as an exposed word, and it's in the command-line header ""EmulationStation, a graphical front-end for ROM browsing.". There's also something in an error message or something, and in Readme.md, but nothing really in the UI.
• The edit entry for that screen says "EDIT GAME METADATA" (which, probably, would now say "GAME" or "FOLDER" depending on the type if you feel like it)
• Technically, you can have games that aren't ROMs (executables, launch scripts, etc). But, at the end of the day, it really is about consistency with the rest of the UI - we refer to entries as "games" and "folders", and my preference would be staying as such.

A bit long, apologies, but hopefully will relay where I'm coming from here.

[Gemba]

I am ok with your justification, better avoid "surprises" for the end-user and step-back a little on technical preciseness. Did adjust the subtitle to "GAME: ..."

[pjft]

Thank you.