Refactorings and two cornercases of 'screensaver enhanced controls'

[Gemba]

Hi @pjft as noted I have added a

• constant variable for -1 (commit 0b408ca)
• did some refactorings and while being at it I discovered two cosmetic cornercases (commit 2537965)
• integrated your remaining changes of #847 on top (commit 6f230a5)

With #850 (currently also in this PR as 9853840) I was not able to reproduce my issue nor the issue from user sleve in the forum.

Let me know any Qs and also if I should squash / reapply the PR once it is OK from your side.

[pjft]

Thanks. This should be good - let me first close and submit #847 for easier traceability (and reversion if needed).

I just added a request to leave a comment there. I should fix this today/tomorrow, and we can then move forward.

[pjft]

I have now merged my code. Feel free to rebase it and we can then merge this. Thank you!

[Gemba]

As I wrote the comment I saw a way to integrate it into setCursor() - with an flag. If you think this commit 72536f6 is more maintainable, we can use that one. Otherwise I revert that commit.

On my side this line throw a SIGSEGV after returning from a game and having it launched via screensaver. It also happened on the current main branch. Can you verify that? In any case it does not hurt to jump out earlier after select or starting a game, as the screensaver is to be ended anyway.

[pjft]

Thank you. I haven't tested it yet, but the code looks ok. Could you squash it into a single commit and I'll merge? Thanks!

[Gemba]

Left the one file out, moved the input consume before button evaluation, squashed the remainder.

I am happy that I could help.

[pjft]

You helped a lot here - thank you!