search

RetroPie / RetroPie-Setup

Shell script to set up a Raspberry Pi/Odroid/PC with RetroArch emulator and various cores
Other
10.07k stars 1.39k forks source link

PcEngine/TurboGrafx emulator broken #225

Closed 4ch1m closed 11 years ago

4ch1m commented 11 years ago

The PC-Engine/TurboGrafx-emulator (mednafen) obviously isn't included in "libretrocores.shinc" anymore. :-( Any reason for that?

However, the "retropiesetup.shinc" routines still check for it:

...
    checkFileExistence "`find $rootdir/emulatorcores/mednafen-pce-libretro/ -name "*libretro*.so"`"
...

"supplementary.shinc" also still tries to include mednafen when creating the systems-configuration-file for EmulationStation:

...
emulator "PC Engine/TurboGrafx 16" generic "/usr/local/bin/retroarch" "-L `find $rootdir/emulatorcores/mednafen-pce-libretro/ -name "*libretro*.so"` --config $rootdir/configs/all/retroarch.cfg --appendconfig $rootdir/configs/pcengine/retroarch.cfg %p"
emulator_roms "PC Engine/TurboGrafx 16" "$rootdir/roms/pcengine"
...

... which finally creates this result for "es_systems.cfg":

DESCNAME=PC Engine/TurboGrafx 16
NAME=pcengine
PATH=/home/pi/RetroPie/roms/pcengine
EXTENSION=.pce
COMMAND=/home/pi/RetroPie/supplementary/runcommand/runcommand.sh 1 "retroarch -L  --config /home/pi/RetroPie/configs/all/retroarch.cfg --appendconfig /home/pi/RetroPie/configs/pcengine/retroarch.cfg %ROM%"
PLATFORMID=34

(The call to the .so-file is missing!)

So... basically this leaves a non-functional section in EmulationStation.

Hope this can be fixed.

Thanks!

petrockblog commented 11 years ago

The reason is that I do not find the repo for the PCEngine libretro core anymore. The precompiled PCEngine core, however, is included in the downloadable binaries so that the settings in es_systems.cfg still makes sense! It would be best, if we could address the sources of the libretro PCEngine core again somehow.

4ch1m commented 11 years ago

Hmmm... but you can't selectively install individual binary-components after having compiled all emulators by yourself, can you? If you run the binary-installation then all other (freshly compiled) binaries will be overwritten by the one from the repo, right?

Regarding the repo for mednafen-libretro... what about this:

https://github.com/ficoos/mednafen-pce-libretro

petrockblog commented 11 years ago

That is great - thanks for the link! The source-based installation routine for this core will be added to the Script with the next update!

petrockblog commented 11 years ago

The Mednafen-PCE-libretro core is included in the source-based installation now.