search

RetroPie / RetroPie-Setup

Shell script to set up a Raspberry Pi/Odroid/PC with RetroArch emulator and various cores
Other
10.07k stars 1.39k forks source link

scummvm unable to change extrapath #3748

Closed voggur closed 1 year ago

voggur commented 1 year ago

I had alot of confusion why extrapath parameter was always resetting to the default parameter. In scummvm.sh this is hard-coded will causes scummvm to reset this parameter. My problems was solved be editing the scummvm.sh $md_inst/bin/scummvm --fullscreen --joystick=0 --extrapath="$md_inst/extra" "\$game" to $md_inst/bin/scummvm --fullscreen --joystick=0 "\$game" I suggest updating this coed as this is already set in scummvm.ini and should not be necessary and could cause user confusion.

https://github.com/RetroPie/RetroPie-Setup/blob/5f2b85a70640b34a547d3b2e51716d5752bef604/scriptmodules/emulators/scummvm.sh#L89C48-L89C48

cmitu commented 1 year ago

That's a good point, but scummvm.ini doesn't exist before a 1st run and there's no default location in scummvm for extrapath. Right now it only contains the virtual keyboard assets - what your use case for choosing a different extrapath ?

voggur commented 1 year ago

I have my folder set to "~/RetroPie/roms/scummvm/scummvm-extra/"

  1. for ease access to add files like MT-32 emulation and soundfont.
  2. Some of this files like .sf2 can be large and "roms" directory is smb mounted to my file-server.
cmitu commented 1 year ago

@voggur we removed the hardcoded --extrapath in #3751, it should make it easier for user to choose their own folder without being overridden by scummvm's start-up script.

Thank you for raising this up.