RetroPie / RetroPie-Setup

Shell script to set up a Raspberry Pi/Odroid/PC with RetroArch emulator and various cores
Other
10k stars 1.38k forks source link

joy2key: fix generic mappings definition #3861

Closed cmitu closed 5 months ago

cmitu commented 5 months ago

Besides the mappings parsed from RetroArch's auto-configuration profiles, there's a generic mapping used for gamepads that don't have a profile saved. Unfortunately this never worked, since the initialization of the mapping - in the add_mappings function - had the buttons and hats parameters switched. This changeset fixes this, creating a correct mapping.

The issue was reported in https://retropie.org.uk/forum/topic/35063/, joy2key_sdl would crash with a Python3 error since the (wrong) generic mapping would produce the incorrect data type and values for the filter_active_events method.