search

RetroPie / RetroPie-Setup

Shell script to set up a Raspberry Pi/Odroid/PC with RetroArch emulator and various cores
Other
10k stars 1.38k forks source link

Put programmable completion file to /etc/bash_comletion.d/ #3875

Closed Gemba closed 5 months ago

Gemba commented 5 months ago

cf. https://retropie.org.uk/forum/post/295194

Also the fn remove_skyscraper() was present two times. Merged them together and added a prompt if skyscraper's cache should also be cleared.

Gemba commented 5 months ago

Haha. Just noticed #3872

Anyhow, I also adressed another issue.

joolswills commented 4 months ago

@Gemba Sorry - I missed this when I merged. The remove function can't be interactive as it breaks my automatic binary builds (and any other automated scripts that use the retropie commandline interface)

Instead of asking about purging, maybe don't remove the cache folder, and instead set _INFMSGS+=("Some message") which will show in a dialog after removing from RetroPie-Setup. This could instruct the user that it's left the cache files and they can remove manually or something ? Or just remove the cache files and inform the user.

Gemba commented 4 months ago

Sure thing, no worries. I filed a PR.

I leave it up to the user if the cache should be zapped manually.